Skip to content

fix: release closed origin header session pages - #156

Open
AVANT-ICONIC wants to merge 3 commits into
mainfrom
fix/origin-headers-release-closed-pages
Open

fix: release closed origin header session pages#156
AVANT-ICONIC wants to merge 3 commits into
mainfrom
fix/origin-headers-release-closed-pages

Conversation

@AVANT-ICONIC

@AVANT-ICONIC AVANT-ICONIC commented Aug 27, 2026

Copy link
Copy Markdown
Owner

Summary

  • release session-owned OriginHeaders bookkeeping when a Playwright page closes
  • remove close listeners during explicit disposal so live pages do not retain the OriginHeaders instance
  • clean up the listener transactionally when route registration fails
  • reconcile pages that close while async route registration is still pending
  • preserve direct OriginHeaders.install(page) behavior and surviving sibling routes

Closes #155.

Verification gate

  • focused lifecycle regressions for close, sibling survival, route failure, and registration race
  • existing OriginHeaders route/security composition regressions
  • full unit/performance + browser matrix + package smoke + Docker
  • exact diff and fresh main/head audit before merge

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 27, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 47 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3715bb52-819b-4338-acd2-a287507b0cf3

📥 Commits

Reviewing files that changed from the base of the PR and between 0d2fc91 and e866bab.

📒 Files selected for processing (3)
  • src/core/OriginHeaders.ts
  • tests/unit/OriginHeadersSessionLifecycle.test.ts
  • tests/unit/OriginHeadersSessionRouting.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

reliability: release closed pages from OriginHeaders session ownership

1 participant

@AVANT-ICONIC